tag:blogger.com,1999:blog-29853730.post6267789512054675714..comments2008-09-22T15:37:02.395+03:00gorkemnoreply@blogger.comBlogger5125tag:blogger.com,1999:blog-29853730.post-3266369117831940862008-09-22T15:37:00.000+03:002008-09-22T15:37:00.000+03:00I am glad you have found it helpful.gorkemhttp://www.blogger.com/profile/05244653393745344494noreply@blogger.comtag:blogger.com,1999:blog-29853730.post-15541990930413203902008-09-22T00:42:00.000+03:002008-09-22T00:42:00.000+03:00Hi,<BR/><BR/>Very interesting post.<BR/><BR/>We have a similar policy at the place I work. The difference is that we have mandatory peer reviews for any commit, and formal inspections (similar to your review process) for big or important chunks of functionality.<BR/><BR/>The problems we have here today is that the formal inspections are held by managers and the architect, so it looks more like a scrutiny than a team process. Also another problem is that doing the peer review of a big commit can be a pain in the ass :)<BR/><BR/>I will base on some of your ideas to try to improve our review process, thanks for sharing it!Domingos Netohttp://www.blogger.com/profile/16748499695622931125noreply@blogger.comtag:blogger.com,1999:blog-29853730.post-80442475700780086102008-09-20T20:13:00.000+03:002008-09-20T20:13:00.000+03:00@joakime. I have not tried to jupiter plugin because we have some groups in the organization that does not use Eclipse for daily development we focused on tools that was independent from IDE.<BR/><BR/>@Anonymous. I guess post is not clear on it but the biggest mistake you can do is discussing formatting issues. The review of code comments is also part of the review and as well as the unit tests. Also let's not forget, the bugs are made by those people who know how they should program.gorkemhttp://www.blogger.com/profile/05244653393745344494noreply@blogger.comtag:blogger.com,1999:blog-29853730.post-49830060472214016392008-09-20T19:53:00.000+03:002008-09-20T19:53:00.000+03:00I dont see any point of code review. how does it help any one? do you guys argue about formatting and using bracelets ? we all know how we should program and i dont see any point of that. however i would like to see review of javadoc comments. that would have more sense.Anonymousnoreply@blogger.comtag:blogger.com,1999:blog-29853730.post-76442729244351555912008-09-19T17:37:00.000+03:002008-09-19T17:37:00.000+03:00Speaking as a person that helps maintain a set of tooling for an organization of several hundred developers worldwide, I can say that these same conversations (debates?) occurred here too.<BR/><BR/>However, it all seemed to magically get better with the introduction of the Jupiter code review plugin.<BR/><BR/><A><BR/>http://code.google.com/p/jupiter-eclipse-plugin/<BR/></A><BR/><BR/>It even allowed us to maintain the code review state / status (metadata) within the subversion repository for each project.joakimehttp://www.blogger.com/profile/11919226774248421689noreply@blogger.com